Skip to content
  • John Snow's avatar
    6f84d726
    python: rename 'venv-check' target to 'check-pipenv' · 6f84d726
    John Snow authored
    
    
    Well, Cleber was right, this is a better name.
    
    In preparation for adding a different kind of virtual environment check
    (One that simply uses whichever version of Python you happen to have),
    rename this test 'check-pipenv' so that it matches the CI job
    'check-python-pipenv'.
    
    Remove the "If you don't know which test to run" hint, because it's not
    actually likely you have Python 3.6 installed to be able to run the
    test. It's still the test I'd most prefer you to run, but it's not the
    test you are most likely to be able to run.
    
    Rename the 'venv' target to 'pipenv' as well, and move the more
    pertinent help text under the 'check-pipenv' target.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Reviewed-by: default avatarWillian Rampazzo <willianr@redhat.com>
    Reviewed-by: default avatarWainer dos Santos Moschetta <wainersm@redhat.com>
    Message-id: 20210629214323.1329806-8-jsnow@redhat.com
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    6f84d726
    python: rename 'venv-check' target to 'check-pipenv'
    John Snow authored
    
    
    Well, Cleber was right, this is a better name.
    
    In preparation for adding a different kind of virtual environment check
    (One that simply uses whichever version of Python you happen to have),
    rename this test 'check-pipenv' so that it matches the CI job
    'check-python-pipenv'.
    
    Remove the "If you don't know which test to run" hint, because it's not
    actually likely you have Python 3.6 installed to be able to run the
    test. It's still the test I'd most prefer you to run, but it's not the
    test you are most likely to be able to run.
    
    Rename the 'venv' target to 'pipenv' as well, and move the more
    pertinent help text under the 'check-pipenv' target.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Reviewed-by: default avatarWillian Rampazzo <willianr@redhat.com>
    Reviewed-by: default avatarWainer dos Santos Moschetta <wainersm@redhat.com>
    Message-id: 20210629214323.1329806-8-jsnow@redhat.com
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Loading