Skip to content
  • John Snow's avatar
    00359a71
    jobs: add exit shim · 00359a71
    John Snow authored
    
    
    All jobs do the same thing when they leave their running loop:
    - Store the return code in a structure
    - wait to receive this structure in the main thread
    - signal job completion via job_completed
    
    Few jobs do anything beyond exactly this. Consolidate this exit
    logic for a net reduction in SLOC.
    
    More seriously, when we utilize job_defer_to_main_loop_bh to call
    a function that calls job_completed, job_finalize_single will run
    in a context where it has recursively taken the aio_context lock,
    which can cause hangs if it puts down a reference that causes a flush.
    
    You can observe this in practice by looking at mirror_exit's careful
    placement of job_completed and bdrv_unref calls.
    
    If we centralize job exiting, we can signal job completion from outside
    of the aio_context, which should allow for job cleanup code to run with
    only one lock, which makes cleanup callbacks less tricky to write.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20180830015734.19765-4-jsnow@redhat.com
    Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    00359a71
    jobs: add exit shim
    John Snow authored
    
    
    All jobs do the same thing when they leave their running loop:
    - Store the return code in a structure
    - wait to receive this structure in the main thread
    - signal job completion via job_completed
    
    Few jobs do anything beyond exactly this. Consolidate this exit
    logic for a net reduction in SLOC.
    
    More seriously, when we utilize job_defer_to_main_loop_bh to call
    a function that calls job_completed, job_finalize_single will run
    in a context where it has recursively taken the aio_context lock,
    which can cause hangs if it puts down a reference that causes a flush.
    
    You can observe this in practice by looking at mirror_exit's careful
    placement of job_completed and bdrv_unref calls.
    
    If we centralize job exiting, we can signal job completion from outside
    of the aio_context, which should allow for job cleanup code to run with
    only one lock, which makes cleanup callbacks less tricky to write.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    Message-id: 20180830015734.19765-4-jsnow@redhat.com
    Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Loading